operator: fix 1.25 install #39554
operator: fix 1.25 install #39554
Conversation
There were a few issues here: * We always used the old versions for prune, and only sometimes added the new ones. This means on 1.25 we get a bunch of errors * We never based the version to the helm renderer, so its ignored and we always use the old API versions. This PR fixes both of these. A lot of plumbing to get the version through
|
/cherrypick release-1.14 We want it there, but should make sure we add postsubmit to that branch as well |
|
@howardjohn: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -71,7 +72,7 @@ var ( | |||
| testClient client.Client | |||
| testReconcileOperator *istiocontrolplane.ReconcileIstioOperator | |||
|
|
|||
| allNamespacedGVKs = append(helmreconciler.NamespacedResources, | |||
| allNamespacedGVKs = append(helmreconciler.NamespacedResources(&version.Info{Major: "1", Minor: "25"}), | |||
There was a problem hiding this comment.
LGTM, except here, if minor version 25 can be replaced with other one, could we defined a constant for it, including the change at L#209 in this file ?
|
@howardjohn: new pull request created: #39564 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* operator: fix 1.25 install There were a few issues here: * We always used the old versions for prune, and only sometimes added the new ones. This means on 1.25 we get a bunch of errors * We never based the version to the helm renderer, so its ignored and we always use the old API versions. This PR fixes both of these. A lot of plumbing to get the version through * lint (cherry picked from commit 349c47e)
* operator: fix 1.25 install (#39554) * operator: fix 1.25 install There were a few issues here: * We always used the old versions for prune, and only sometimes added the new ones. This means on 1.25 we get a bunch of errors * We never based the version to the helm renderer, so its ignored and we always use the old API versions. This PR fixes both of these. A lot of plumbing to get the version through * lint (cherry picked from commit 349c47e) * operator: fix remaining issue for 1.25 in cluster controller (#39587) (cherry picked from commit 89aadd6) * Fix operator test on 1.25 (#39883) (cherry picked from commit 686aa16) * release note
* feat: cherry pick operator: fix 1.25 install (istio#39554) 349c47e * feat: operator: fix remaining issue for 1.25 in cluster controller (istio#39587) 89aadd6 * feat: ignore replicaCount when autoscale is enabled (istio#36928) 28c8811 * feat: pdb v1 and autoscaler v2 ed2de8c, c3d3d13, 57b90f0 --------- Co-authored-by: jst <jst@meitu.com>
There were a few issues here:
the new ones. This means on 1.25 we get a bunch of errors
always use the old API versions.
This PR fixes both of these. A lot of plumbing to get the version
through
Please provide a description of this PR: