Change pilot CRD client to handle multiple apiGroupVersions #3830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3830 +/- ##
=======================================
+ Coverage 76% 76% +1%
=======================================
Files 297 297
Lines 27075 27257 +182
=======================================
+ Hits 20407 20566 +159
Misses 5358 5358
- Partials 1310 1333 +23
Continue to review full report at Codecov.
|
pilot/cmd/istioctl/main.go
Outdated
| "github.com/spf13/cobra/doc" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/apimachinery/pkg/runtime/serializer" |
There was a problem hiding this comment.
Make sure you run bin/fmt.sh on the changes files. Imports are unsorted.
pilot/pkg/config/kube/crd/client.go
Outdated
| errs = multierror.Append(errs, err) | ||
| } | ||
| return errs | ||
| } | ||
|
|
||
| // ConfigDescriptor for the store | ||
| func (cl *Client) ConfigDescriptor() model.ConfigDescriptor { | ||
| return cl.descriptor | ||
| d := make(model.ConfigDescriptor, 0) |
There was a problem hiding this comment.
make(type, 0, len(cl.clientset)
|
@xiaolanz PR needs rebase |
|
/retest |
|
@xiaolanz PR needs rebase |
|
PTAL |
| "github.com/spf13/cobra" | ||
| "github.com/spf13/cobra/doc" |
There was a problem hiding this comment.
Newline requried between github and k8s imports.
There was a problem hiding this comment.
Feel free to ignore this if go fmt is removing the newline.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ayj, diemtvu Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@xiaolanz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Add authentication policy to istio config. * Merge #3830 * Add IstioConfigTest for authentication policy type. * Change Authentication policy type to authentication-policy to match with schema name. It's still a requirement. * Change AuthenticationPolicyByDestination to return *Config. * Patch generate.sh from https://github.com/xiaolanz/istio/blob/707afce3a0538b7cf4e6624928a605a68063b81f/pilot/pkg/config/kube/crd/generate.sh and change CRD type back to Policy. * Lint * Rebase * Add tracking bug for global config * Lint
Wrap CRD client to a set of rest clients each for one apiGroupVersion.
Modify istioctl to handle existing config.istio.io group for Mixer resources.
Addresses #3586, #3880