Skip to content

Rename and fix one bug in nodeagent.yaml #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2018
Merged

Rename and fix one bug in nodeagent.yaml #3824

merged 2 commits into from
Feb 28, 2018

Conversation

wattli
Copy link
Contributor

@wattli wattli commented Feb 27, 2018

No description provided.

@wattli wattli requested review from myidpt and a team February 27, 2018 23:34
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: wenchenglu

Assign the PR to them by writing /assign @wenchenglu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

myidpt
myidpt reviewed Feb 27, 2018
View reviewed changes
security/cmd/node_agent_k8s/nodeagent.yaml
@@ -40,4 +40,4 @@ spec:
- name: flexvol-driver-host
hostPath:
type: DirectoryOrCreate
path: /home/kubernetes/flexvolume
path: /home/kubernetes/flexvolume/nodeagent~uds
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ~ valid in the FS path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's actually purposed designed by flexvolume: https://screenshot.googleplex.com/xicQCYS7N3a

@istio-testing
Copy link
Collaborator

istio-testing commented Feb 28, 2018 •
edited
Loading

@wattli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests.sh 19e8069 link /test e2e-simple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli wattli merged commit 1b60224 into istio:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wattli @istio-merge-robot @istio-testing @myidpt @googlebot