fix race test for TestWatchChanges #3806
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3806 +/- ##
=======================================
+ Coverage 76% 76% +1%
=======================================
Files 291 291
Lines 26743 26983 +240
=======================================
+ Hits 20237 20502 +265
+ Misses 5201 5169 -32
- Partials 1305 1312 +7
Continue to review full report at Codecov.
|
mixer/pkg/runtime2/listener_test.go
Outdated
|
|
||
| "github.com/gogo/protobuf/proto" | ||
|
|
||
| "sync" |
There was a problem hiding this comment.
file is not properly goimport'ed, synch should be between reflect and testing
standard is:
go packages (alphabetized)
<space>
github packages (alphabetized)
<space>
istio packages (alphabetized)
|
/test e2e-bookInfo |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ozevren The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@xiaolanz: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
address: #3780
go test --v ./mixer/pkg/runtime2/... --race -run TestWatchChanges