Add additional expression tests #3804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3804 +/- ##
=======================================
+ Coverage 76% 77% +1%
=======================================
Files 291 291
Lines 26869 26458 -411
=======================================
- Hits 20379 20151 -228
+ Misses 5178 5043 -135
+ Partials 1312 1264 -48
Continue to review full report at Codecov.
|
|
/test istio-unit-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
mixer/pkg/il/testing/tests.go
Outdated
| @@ -305,6 +305,50 @@ end`, | |||
| R: true, | |||
| conf: exprEvalAttrs, | |||
| }, | |||
| // use request.header (without "s" at the end), as it is the one in the original attributeset. | |||
There was a problem hiding this comment.
should we update the testing set to match the actual vocab (request.headers) so as not to sow confusion?
There was a problem hiding this comment.
Added 0.6 attribute set as a separate set.
I'd rather not pollute the previous tests that I copied over from previous expression tests.
|
/test e2e-bookInfo |
|
/test e2e-simple |
Wrote these tests to quickly verify the evaluator behavior outlined in #3734.