Adding requirement for codecov package #3884
Conversation
.codecov.yml
Outdated
| @@ -1,6 +1,7 @@ | |||
| coverage: | |||
| precision: 0 | |||
| round: up | |||
| range: 70..90 | |||
There was a problem hiding this comment.
uh that's low - I don't think 90 is enough for green
There was a problem hiding this comment.
what do you advise ?
There was a problem hiding this comment.
updated to 60..99
b5abd1c to
0fe0dab
Compare
|
@sebastienvas: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly, yutongz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
A recent PR (istio#3999) adds the requirement of code coverage for the packages, but another PR (istio#3884) was merged, and the package security/cmd/flexvolume/driver's coverage was decreased significantly. Ideally the package's coverage should be recovered, but the requirement should be released for the time being, otherwise any further codecov check will fail. Updates istio#4034
A recent PR (#3999) adds the requirement of code coverage for the packages, but another PR (#3884) was merged, and the package security/cmd/flexvolume/driver's coverage was decreased significantly. Ideally the package's coverage should be recovered, but the requirement should be released for the time being, otherwise any further codecov check will fail. Updates #4034
This basically combines all the packages requirement files into one and update them based on last run. We should update after fixit.
The pkg_check will validate the codecov.report from the codecov.requirement