Skip to content

Conversation

ayj
Copy link
Contributor

@ayj ayj commented Mar 1, 2018

Other components organize code under cmd and pkg subdirectores,
where the application entrypoint is located in respective
cmd/<binary> subdirectory. Do the same for istioctl.

Other components organize code under `cmd` and `pkg` subdirectores,
where the application entrypoint is located in respective
`cmd/<binary>` subdirectory. Do the same for istioctl.
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #3881 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3881    +/-   ##
=======================================
- Coverage      76%     76%   -<1%     
=======================================
  Files         296     296            
  Lines       27003   27112   +109     
=======================================
+ Hits        20405   20467    +62     
- Misses       5297    5335    +38     
- Partials     1301    1310     +9
Impacted Files Coverage Δ
istioctl/cmd/istioctl/gendeployment/helm.go 100% <ø> (ø)
istioctl/cmd/istioctl/gendeployment/cmd.go 41% <ø> (ø)
istioctl/cmd/istioctl/gendeployment/yaml.go 0% <ø> (ø)
pilot/pkg/bootstrap/monitoring.go 64% <0%> (-16%) ⬇️
mixer/adapter/list/regexList.go 69% <0%> (-9%) ⬇️
mixer/adapter/prometheus/prometheus.go 80% <0%> (-3%) ⬇️
mixer/adapter/stdio/zap.go 99% <0%> (-1%) ⬇️
mixer/adapter/prometheus/server.go 95% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (ø) ⬇️
mixer/adapter/list/list.go 95% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c79ee...b32dbc5. Read the comment docs.

@geeknoid
Copy link
Contributor

geeknoid commented Mar 1, 2018

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit e86799e into istio:master Mar 1, 2018
@istio-testing
Copy link
Collaborator

istio-testing commented Mar 1, 2018

@ayj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh b32dbc5 link /test istio-pilot-e2e
prow/e2e-simpleTests.sh b32dbc5 link /test e2e-simple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj ayj deleted the add-cmd-subdirectory-to-istioctl branch April 30, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants