Remove common-protos #38546
Merged
Remove common-protos #38546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
reviewed
Apr 25, 2022
| @@ -107,13 +104,6 @@ update-common: | |||
| @cp -a $(TMP)/common-files/files/* $(shell pwd) | |||
| @rm -fr $(TMP)/common-files | |||
|
|
|||
| update-common-protos: | |||
There was a problem hiding this comment.
do not change this, this file is synced with common-files
There was a problem hiding this comment.
I donot know why the proto is used in main repo. Can you clarify
There was a problem hiding this comment.
Makefile.common.mk does many many things, one of them is update-common-protos.
If you make this change, when update-common is ran (which is done automatically) it will revert this change anyways
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| _ "google.golang.org/protobuf/types/known/anypb" |
howardjohn
approved these changes
Apr 25, 2022
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| _ "google.golang.org/protobuf/types/known/anypb" |
|
Note that the common files were set back to their prior values when the next common-files update happened. This changes need to be done upstream in common-files. |
GregHanson
pushed a commit
to GregHanson/istio
that referenced
this pull request
May 13, 2022
* Remove common-protos * Make gen
istio-testing
pushed a commit
that referenced
this pull request
May 13, 2022
* operator: update golden files (#38714) Currently operator tests use a snapshot of the manifests for tests to avoid churn. Update these to meet current state of the world. All changes are autogenerated * update autoscaling version to v2beta2 (#37872) * update autoscaling version to v2beta2 * integrate with api repo changes * address comments * update helm gateway * address comments, fix boolean condition * modify pruning based on k8s version * fix comments * bump pdb version to policy/v1 (#38814) * add v1 pdb * release note * Remove common-protos (#38546) * Remove common-protos * Make gen Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: Xinnan Wen <iamwen@google.com> Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Looks we do not need them anymore. And there is no automatically sync with common-files repo