[tf] Support echo egress to ext-authz #38540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The echos are currently restricted to just the other echo namespaces, which prevents egress to the external authz server, if it's in another namespace. This PR changes the logic so that egress is allowed to any namespace that has been allocated by the test framework up to the point the echos are created. Fixes istio#38451
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
howardjohn
approved these changes
Apr 25, 2022
GregHanson
pushed a commit
to GregHanson/istio
that referenced
this pull request
May 18, 2022
The echos are currently restricted to just the other echo namespaces, which prevents egress to the external authz server, if it's in another namespace. This PR changes the logic so that egress is allowed to any namespace that has been allocated by the test framework up to the point the echos are created. Fixes istio#38451
GregHanson
pushed a commit
to GregHanson/istio
that referenced
this pull request
Aug 17, 2022
The echos are currently restricted to just the other echo namespaces, which prevents egress to the external authz server, if it's in another namespace. This PR changes the logic so that egress is allowed to any namespace that has been allocated by the test framework up to the point the echos are created. Fixes istio#38451
Merged
istio-testing
pushed a commit
that referenced
this pull request
Aug 17, 2022
* [tf] Support echo egress to ext-authz (#38540) The echos are currently restricted to just the other echo namespaces, which prevents egress to the external authz server, if it's in another namespace. This PR changes the logic so that egress is allowed to any namespace that has been allocated by the test framework up to the point the echos are created. Fixes #38451 * [tf] Consistent namespace creation (#38969) This reverts commit 26dc4d1. Currently, the logic for creating a namespace is slightly different in `newKube` vs `claimKube`, but it shouldn't be. This change extracts the logic into a common function. Also does some general cleanup to consolidate code. Co-authored-by: Nathan Mittler <nmittler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The echos are currently restricted to just the other echo namespaces, which prevents egress to the external authz server, if it's in another namespace.
This PR changes the logic so that egress is allowed to any namespace that has been allocated by the test framework up to the point the echos are created.
Fixes #38451
Please provide a description of this PR: