refactor eds functions #37892
Merged
refactor eds functions #37892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
howardjohn
reviewed
Mar 14, 2022
hzxuzhonghu
reviewed
Mar 17, 2022
| @@ -360,7 +361,7 @@ func (s *ServiceEntryStore) serviceEntryHandler(_, curr config.Config, event mod | |||
| fullPush := len(configsUpdated) > 0 | |||
| // if not full push needed, at least one service unchanged | |||
| if !fullPush { | |||
| s.edsUpdate(serviceInstances, true) | |||
| s.queueEdsPush(serviceInstances) | |||
There was a problem hiding this comment.
could we call edsUpdate and edsCacheUpdate?
queueEdsPush can not express this is a doing cache update -> push in searial
There was a problem hiding this comment.
Sorry. I did not understand. We already have edsUpate and edsCacheUpdate that call xds update functions. What are you suggesting here?
There was a problem hiding this comment.
I mean keep the name edsUpdate and edsCacheUpdate
There was a problem hiding this comment.
Changed a bit. PTAL
hzxuzhonghu
reviewed
Mar 17, 2022
| } | ||
|
|
||
| // buildEndpoints builds endpoints for the instance keys. | ||
| func (s *ServiceEntryStore) buildEndpoints(keys map[instancesKey]struct{}) map[instancesKey][]*model.IstioEndpoint { |
There was a problem hiding this comment.
I am all for this abstraction
|
/test integ-security_istio |
aryan16
pushed a commit
to aryan16/istio
that referenced
this pull request
Mar 28, 2022
* refactor eds functions Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix test Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * revert Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
GregHanson
pushed a commit
to GregHanson/istio
that referenced
this pull request
Aug 3, 2022
* refactor eds functions Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix test Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * revert Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Merged
istio-testing
pushed a commit
that referenced
this pull request
Aug 4, 2022
* Fix TestEdsCache flake (#37824) * Run eds cache update synchrounously and wait for complete * update * Fix dead lock * Fix goroutine leak * make use of channel rather than waitgroup to prevent blocking * refactor eds functions (#37892) * refactor eds functions Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix test Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * revert Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * fix Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * workload instance cause stale CDS clusters of type STRICT_DNS (#39947) * workload instance cause stale CDS clusters with of type STRICT_DNS * added release note * fewer full push triggers * code review comments for release note * extend logic for DNS_ROUND_ROBIN * update trigger reason to EndpointUpdate * add unit tests * resolve cherrypick conflicts Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com> Co-authored-by: Rama Chavali <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.