Skip to content

ExternalService bug fix for discovery type DNS #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2018
Merged

ExternalService bug fix for discovery type DNS #3786

merged 1 commit into from
Feb 27, 2018

Conversation

GregHanson
Copy link
Member

If no hosts are provided for an ExternalService of discovery type DNS, the hosts field should be used to populate the hosts field for CDS

@GregHanson GregHanson added this to the Istio 0.7 milestone Feb 26, 2018
@GregHanson GregHanson requested review from ijsnellf and a team February 26, 2018 21:53
@codecov
Copy link

codecov bot commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #3786 into master will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3786   +/-   ##
======================================
+ Coverage      76%     76%   +1%     
======================================
  Files         291     291           
  Lines       26830   26890   +60     
======================================
+ Hits        20350   20399   +49     
- Misses       5175    5180    +5     
- Partials     1305    1311    +6
Impacted Files Coverage Δ
pilot/pkg/proxy/envoy/v1/externalservice.go 99% <100%> (+1%) ⬆️
mixer/adapter/stackdriver/stackdriver.go 55% <0%> (-15%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 64% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-2%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (-1%) ⬇️
pilot/pkg/proxy/envoy/v2/mesh.go 75% <0%> (ø) ⬇️
tools/githubContrib/githubContrib.go 7% <0%> (ø) ⬇️
mixer/adapter/list/list.go 95% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbab37...8859779. Read the comment docs.

@GregHanson GregHanson changed the title ExternalService bug fix for discovery type DNS [WIP] ExternalService bug fix for discovery type DNS Feb 27, 2018
@GregHanson GregHanson changed the title [WIP] ExternalService bug fix for discovery type DNS ExternalService bug fix for discovery type DNS Feb 27, 2018
@ijsnellf
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ijsnellf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 5a3de49 into istio:master Feb 27, 2018
@istio-testing
Copy link
Collaborator

istio-testing commented Feb 27, 2018 •
edited
Loading

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests.sh 8859779 link /test e2e-bookInfo
prow/e2e-simpleTests.sh 8859779 link /test e2e-simple

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf ijsnellf mentioned this pull request Feb 27, 2018
Closed
@GregHanson
Copy link
Member Author

resolves #3773

@GregHanson GregHanson deleted the external-dns-bugfix branch February 27, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ijsnellf ijsnellf ijsnellf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ijsnellf ijsnellf

Labels
area/networking
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@GregHanson @ijsnellf @istio-merge-robot @istio-testing @googlebot