Gateway hosts may contain wildcards #3634
Conversation
Co-authored-by: Zachary LaVallee <zlavallee@pivotal.io> Co-authored-by: Nino Kodabande <nkodabande@suse.com>
|
/test istio-presubmit |
| for _, host := range hosts { | ||
| if strings.HasSuffix(host, matchCriteria[1:]) { | ||
| matchingHosts = append(matchingHosts, host) | ||
| } |
There was a problem hiding this comment.
Are we sticking to prefix based matches only? Or should we allow regex matches? Or wildcards in any position like foo.*.com ?
I am okay with the prefix based match as a first cut, but wondering if such use cases exist in cf world.
There was a problem hiding this comment.
No use cases that I know of....
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@rosenhouse: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hacking away at #3410