Skip to content

configgentest: avoid running kubecontroller 2x #36332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2021
Merged

configgentest: avoid running kubecontroller 2x #36332

merged 4 commits into from
Dec 16, 2021

Conversation

stevenctl
Copy link
Contributor

It seems we're calling the kubecontrollers Run method 2x in our tests.

@stevenctl stevenctl requested review from a team as code owners December 1, 2021 22:32
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 1, 2021
@stevenctl stevenctl added release-notes-none Indicates a PR that does not require release notes. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Dec 1, 2021
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 1, 2021
@stevenctl stevenctl force-pushed the fix-cgt branch 2 times, most recently from 7deb922 to 73e317f Compare December 3, 2021 21:45
Steven Landow added 3 commits December 16, 2021 13:11
configgentest: avoid running kubecontroller 2x
4ccf639 
Change-Id: I8101701256e101a93aef14e0e60c36538a8b1f1b
fix hanging tests that use fake kube directly
8a6dca3 
Change-Id: If052a24b9ade11e42f870651c1385fd1f61fb757
fix test that use fake k8s directly
8e2eb56 
Change-Id: Ic773169a809662a1f14c2e59cb523c9785483411
add before run in non-configgen test
7358196 
Change-Id: I5ec4f820a6b0e56d5c6fb6755450cc08776bf2ef
@istio-testing istio-testing merged commit 26e13f9 into istio:master Dec 16, 2021
hzxuzhonghu added a commit to hzxuzhonghu/istio that referenced this pull request Dec 31, 2021
@hzxuzhonghu
Revert "configgentest: avoid running kubecontroller 2x (istio#36332)"
cb80bd3 
This reverts commit 26e13f9.
istio-testing pushed a commit that referenced this pull request Jan 5, 2022
@hzxuzhonghu
Fix flake TestEndpointsDeduping, it is caused by running kube control…
5bf146f 
…ler twice (#36675)

* Revert "configgentest: avoid running kubecontroller 2x (#36332)"

This reverts commit 26e13f9.

* Fix TestEndpointsDeduping flake

* Run before wait sync

* rm debug log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenctl @howardjohn @istio-testing