Skip to content

The output of "istioctl ps" cmd show the cluster(k8s) name which a pod belongs for multi-cluster #36292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2022
Merged

The output of "istioctl ps" cmd show the cluster(k8s) name which a pod belongs for multi-cluster #36292

merged 3 commits into from
Jan 13, 2022

Conversation

miaoyq
Copy link
Contributor

@miaoyq miaoyq commented Nov 30, 2021 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
fix #36290

@miaoyq
add clusterID in the response of /debug/syncz
c7c2598 
Signed-off-by: Yanqiang Miao <miaoyq_2010@163.com>
@miaoyq miaoyq requested review from a team as code owners November 30, 2021 01:24
@istio-policy-bot
Copy link

😊 Welcome @miaoyq! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 30, 2021
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 30, 2021
@istio-testing
Copy link
Collaborator

Hi @miaoyq. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miaoyq miaoyq changed the title Show clusterid in istioctl ps The output of "istioctl ps" cmd show the cluster(k8s) name which a pod belongs Nov 30, 2021
@miaoyq
Copy link
Contributor Author

miaoyq commented Nov 30, 2021

/ok-to-test

@istio-testing
Copy link
Collaborator

@miaoyq: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irisdingbj
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 1, 2021
@miaoyq
add clusterID in output of istioctl ps
0307c84 
Signed-off-by: Yanqiang Miao <miaoyq_2010@163.com>
@miaoyq miaoyq force-pushed the show-clusterid-in-istioctl-ps branch from ed4c589 to 0307c84 Compare December 2, 2021 13:17
@miaoyq
Copy link
Contributor Author

miaoyq commented Dec 3, 2021

/test release-notes_istio

hzxuzhonghu
hzxuzhonghu approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think it's worth a release note

@miaoyq miaoyq requested review from a team as code owners December 6, 2021 08:42
@miaoyq
add release note
a0a5e30 
Signed-off-by: Yanqiang Miao <miaoyq_2010@163.com>
@miaoyq miaoyq force-pushed the show-clusterid-in-istioctl-ps branch from 1d962c4 to a0a5e30 Compare December 6, 2021 08:46
@miaoyq
Copy link
Contributor Author

miaoyq commented Dec 6, 2021

@hzxuzhonghu Thanks for review :-).

@miaoyq
Copy link
Contributor Author

miaoyq commented Dec 16, 2021 •
edited
Loading

@howardjohn Could you take a look at the PR :-)

howardjohn
howardjohn approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from T&R perspective

@miaoyq
Copy link
Contributor Author

miaoyq commented Dec 17, 2021

cc @therealmitchconnors :-)

@miaoyq
Copy link
Contributor Author

miaoyq commented Jan 10, 2022

@esnible Could you please take a look at the PR, Thx :-)

@ericvn
Copy link
Contributor

ericvn commented Jan 10, 2022

Looking at istio.io, I don't see any of the places where istioctl ps is used with example output that is tested. Thus, I don't think any istio.io tests will fail once this is merged, but several pages will have old output without the CLUSTER name.

@miaoyq
Copy link
Contributor Author

miaoyq commented Jan 12, 2022

/test unit-tests_istio

1 similar comment
@miaoyq
Copy link
Contributor Author

miaoyq commented Jan 13, 2022

/test unit-tests_istio

@istio-testing istio-testing merged commit 8b86d2d into istio:master Jan 13, 2022
@miaoyq miaoyq changed the title The output of "istioctl ps" cmd show the cluster(k8s) name which a pod belongs The output of "istioctl ps" cmd show the cluster(k8s) name which a pod belongs for multi-cluster Jan 20, 2022
@Xunzhuo Xunzhuo mentioned this pull request Apr 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

+1 more reviewer

@esnible esnible esnible approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/test and release cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The output of "istioctl ps" cmd should include the cluster(k8s) name which a pod belongs
8 participants
@miaoyq @istio-policy-bot @istio-testing @irisdingbj @ericvn @howardjohn @esnible @hzxuzhonghu