Show pkg name and url when installing istio on VM #3629
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/assign @ldemailly |
|
but how come it didn't download it in that prow job ? |
install/tools/setupIstioVM.sh
Outdated
| @@ -56,6 +56,7 @@ function istioNetworkInit() { | |||
| # will generate and copy the files and install the packages on each machine. | |||
| function istioInstall() { | |||
| echo "*** Fetching istio packages..." | |||
| echo "Downloanding istio-sidecar.deb from {PILOT_DEBIAN_URL}/istio-sidecar.deb" | |||
| # Current URL for the debian files artifacts. Will be replaced by a proper apt repo. | |||
| rm -f istio-sidecar.deb | |||
| echo curl -f -L ${PILOT_DEBIAN_URL}/istio-sidecar.deb > ${ISTIO_STAGING}/istio-sidecar.deb | |||
There was a problem hiding this comment.
the bug (introduced by #2820) is here
please add the missing "" in that echo and you don't need the first one
|
@chxchx: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -58,7 +58,7 @@ function istioInstall() { | |||
| echo "*** Fetching istio packages..." | |||
| # Current URL for the debian files artifacts. Will be replaced by a proper apt repo. | |||
| rm -f istio-sidecar.deb | |||
| echo curl -f -L ${PILOT_DEBIAN_URL}/istio-sidecar.deb > ${ISTIO_STAGING}/istio-sidecar.deb | |||
| echo "curl -f -L ${PILOT_DEBIAN_URL}/istio-sidecar.deb > ${ISTIO_STAGING}/istio-sidecar.deb" | |||
There was a problem hiding this comment.
maybe "Running: curl ..."
but it's fine as is too
fixes #3600