Recompute service account at endpoint shard when all endpoints are removed #36882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
howardjohn
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Nice, LGTM but will let @ramaraochavali or @hzxuzhonghu take a look since I think they are familiar with this code deeply.
hzxuzhonghu
approved these changes
Jan 19, 2022
|
/retest |
|
@howardjohn ping for release notes approval. thanks! |
howardjohn
approved these changes
Jan 21, 2022
|
In response to a cherrypick label: new pull request created: #36939 |
|
In response to a cherrypick label: new pull request created: #36940 |
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Sep 8, 2022
Fixes istio#39652 This reverts istio#36882. At the time, that PR was needed because EDS ServiceAccounts and CDS ServiceAccounts were decoupled; Since istio#39133, this is no longer true, and the fix in 36882 is not needed any longer. This PR *removes* the test added in 36882 (since it tests low level details that are not relevant anymore). It improves the existing TestEndpointFlipFlops test -- while that test *would* have caught the regression, it didn't actually set any service accounts so it was missed. The update changes it to correctly detect the behavior (it now fails without this PR, passes with it).
istio-testing
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Disable full push on scale from 1->0->1 Fixes #39652 This reverts #36882. At the time, that PR was needed because EDS ServiceAccounts and CDS ServiceAccounts were decoupled; Since #39133, this is no longer true, and the fix in 36882 is not needed any longer. This PR *removes* the test added in 36882 (since it tests low level details that are not relevant anymore). It improves the existing TestEndpointFlipFlops test -- while that test *would* have caught the regression, it didn't actually set any service accounts so it was missed. The update changes it to correctly detect the behavior (it now fails without this PR, passes with it). * add note * fix note * Add new SA case
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Sep 12, 2022
* Disable full push on scale from 1->0->1 Fixes istio#39652 This reverts istio#36882. At the time, that PR was needed because EDS ServiceAccounts and CDS ServiceAccounts were decoupled; Since istio#39133, this is no longer true, and the fix in 36882 is not needed any longer. This PR *removes* the test added in 36882 (since it tests low level details that are not relevant anymore). It improves the existing TestEndpointFlipFlops test -- while that test *would* have caught the regression, it didn't actually set any service accounts so it was missed. The update changes it to correctly detect the behavior (it now fails without this PR, passes with it). * add note * fix note * Add new SA case (cherry picked from commit 9f1cbfb)
istio-testing
pushed a commit
that referenced
this pull request
Sep 13, 2022
* SAN improvements (#40863) * wip * wip * Add tests * drop logs * revert changes * Add one more case * Add namespace into SA key as well * Add back svc.ServiceAccounts * add note * lint (cherry picked from commit 0abe39d) * Disable full push on scale from 1->0->1 (#40866) * Disable full push on scale from 1->0->1 Fixes #39652 This reverts #36882. At the time, that PR was needed because EDS ServiceAccounts and CDS ServiceAccounts were decoupled; Since #39133, this is no longer true, and the fix in 36882 is not needed any longer. This PR *removes* the test added in 36882 (since it tests low level details that are not relevant anymore). It improves the existing TestEndpointFlipFlops test -- while that test *would* have caught the regression, it didn't actually set any service accounts so it was missed. The update changes it to correctly detect the behavior (it now fails without this PR, passes with it). * add note * fix note * Add new SA case (cherry picked from commit 9f1cbfb)
yxun
pushed a commit
to yxun/maistra-istio
that referenced
this pull request
Sep 28, 2023
* Disable full push on scale from 1->0->1 Fixes istio/istio#39652 This reverts istio/istio#36882. At the time, that PR was needed because EDS ServiceAccounts and CDS ServiceAccounts were decoupled; Since istio/istio#39133, this is no longer true, and the fix in 36882 is not needed any longer. This PR *removes* the test added in 36882 (since it tests low level details that are not relevant anymore). It improves the existing TestEndpointFlipFlops test -- while that test *would* have caught the regression, it didn't actually set any service accounts so it was missed. The update changes it to correctly detect the behavior (it now fails without this PR, passes with it). * add note * fix note * Add new SA case
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #36465 and #31534.
The sequence to trigger the issue:
"default_validation_context": {}.istio/pilot/pkg/xds/eds.go
Line 150 in 4dea7d9