Add clusterID to x ps #36835
Merged
Add clusterID to x ps #36835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test integ-pilot-istiodremote-tests_istio |
ericvn
reviewed
Jan 14, 2022
howardjohn
approved these changes
Jan 14, 2022
|
@esnible PTAL. |
|
/test all |
zhlsunshine
reviewed
Feb 9, 2022
| @@ -176,8 +178,13 @@ func (s *XdsStatusWriter) setupStatusPrint(drs map[string]*xdsapi.DiscoveryRespo | |||
| } | |||
| cds, lds, eds, rds := getSyncStatus(&clientConfig) | |||
| cp := multixds.CpInfo(dr) | |||
| meta, err := model.ParseMetadata(clientConfig.GetNode().GetMetadata()) | |||
There was a problem hiding this comment.
Is it possible to get the clusterID via similar way from getSyncStatus , just like get cds, lds, eds, rds above?
There was a problem hiding this comment.
Those sync statues are generated from the GenericXdsConfigs in clientConfig, and clusterID, proxyID are from the Node info in the clientConfig. I think they should not be mixed up, but there could be an improvement in the next to unify them to a function like getProxyStatuses.
There was a problem hiding this comment.
@zhlsunshine PTAL, thanks!
|
not stale |
578ac22 to
11a8b50
Compare
hzxuzhonghu
reviewed
Apr 8, 2022
11a8b50 to
557a6a8
Compare
557a6a8 to
b95b6d3
Compare
|
/test integ-security-multicluster_istio |
liamawhite
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
#36290 adds the id to
istioctl ps, and this one adds tox psTo help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.