Skip to content

Always use separate check and report clusters for mixer #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2018
Merged

Always use separate check and report clusters for mixer #3671

merged 2 commits into from
Feb 22, 2018

Conversation

mandarjog
Copy link
Contributor

  1. This ensures that separate stats are collected even if same cluster is used.
  2. For prod use it will be multiple clusters.

@mandarjog mandarjog requested a review from a team February 21, 2018 23:39
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mandarjog
Copy link
Contributor Author

/test istio-pilot-e2e

@costinm
Copy link
Contributor

costinm commented Feb 22, 2018

/lgtm

@mandarjog mandarjog merged commit 97770de into istio:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/perf and scalability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mandarjog @istio-merge-robot @costinm @rshriram @ldemailly @googlebot