Skip to content

Updating to latest fortio #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2018
Merged

Updating to latest fortio #3643

merged 1 commit into from
Feb 21, 2018

Conversation

ldemailly
Copy link
Member

Ran dep ensure --update istio.io/fortio to pick up 0.7.0

@ldemailly ldemailly requested a review from a team February 21, 2018 08:47
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: kyessenov

Assign the PR to them by writing /assign @kyessenov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly
Copy link
Member Author

/test e2e-suite-rbac-auth

@ldemailly ldemailly requested a review from GregHanson February 21, 2018 09:02
@ldemailly ldemailly mentioned this pull request Feb 21, 2018
Closed
@istio-testing
Copy link
Collaborator

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh c112d14 link /test e2e-suite-rbac-auth
prow/istio-pilot-e2e.sh c112d14 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly
Copy link
Member Author

failure is unrelated
I0221 09:35:33.206] --- FAIL: TestPilot/Auth/routing-rules-to-egress (232.80s)

so merging

@ldemailly ldemailly merged commit a57984f into master Feb 21, 2018
@ldemailly ldemailly deleted the fortio_0_7_0 branch February 21, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregHanson GregHanson Awaiting requested review from GregHanson

1 more reviewer

@mandarjog mandarjog mandarjog approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ldemailly @istio-merge-robot @istio-testing @mandarjog @googlebot