Skip to content

Conversation

sebastienvas
Copy link
Contributor

@sebastienvas sebastienvas commented Feb 16, 2018

Apparently zsh arrays index starts at 1 while bash index starts at 0, which is why I got inconsistent results.

@sebastienvas sebastienvas requested review from rkpagadala and a team February 16, 2018 00:57
@rkpagadala
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkpagadala
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yutongz
Copy link
Contributor

yutongz commented Feb 16, 2018

/test e2e-bookInfo
/test e2e-simple

@sebastienvas
Copy link
Contributor Author

/test e2e-bookInfo

@sebastienvas sebastienvas merged commit a015b8c into istio:master Feb 16, 2018
@sebastienvas sebastienvas deleted the cluster branch February 16, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants