-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Upgrade istio-builder image to 0.4.6 #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
what is new in 0.4.6 ? |
/test e2e-smoke |
This change is great for updating the release builds, though it'd be more proper/complete to also remove the following from release/cloud_builder.sh: apt-get -qqy install ruby ruby-dev rubygems build-essential gem install --no-ri --no-rdoc fpm I think your motivation is to update what's run by prow for pre/post-submit, and that's probably controlled elsewhere, but I'm not sure where. E.g., prow/config.yaml (in the test-infra repo) is one possible lead, at least for green-builds. |
0.4.6 comes with fpm installed. See latest update to linux-install-software script istio/test-infra#684 |
/lgtm The file linux-install-bazel seems to have BAZEL_VERSION='0.6.1' in it, so I'm not clear on how a newer 0.7 got into the older image that's being replaced. I don't know what istio/proxy expects these days, but I suppose it's a net win for the release builds that this image is usually used for. It looks like linux-install-golang is using 1.9, though 1.9.3 would be more ideal. I don't know which specific version is in the builder 0.4.5 image so I don't know if this is getting older or staying the same. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattdelco The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Thank you @mattdelco for spotting the versioning discrepancy. Perhaps the previous 0.4.5 image was created with bazel 0.7 and pushed, but such version change remained local and was not merged into test infra. I am not sure if 0.6.1 bazel will break anything. Should we make a new image with the 0.7 bazel and 1.9.3 go as suggested? /cc @sebastienvas |
Afaik istio-builder is only used for release builds in cloud builder, and it's currently not using bazel so the downgrade to 0.6.1 should break anything (except possibly me when I try to experiment with building everything from local source). Prow-builder might be a different story. There is the update bot that builds proxy artifacts in post-submit but I don't know if that uses prow-builder or something else. As for go, it looks like 1.10 is expected soon so regardless of whether we do 1.9 or 1.9.3 it's likely that it'll be reved again soon for 1.10 (1.10 has some caching features that can improve build performance so devs will likely be eager to adopt 1.10). |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
See discussion in #3279
/assgin @mattdelco @sebastienvas @rkpagadala