Skip to content

Conversation

jwendell
Copy link
Member

No description provided.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 12, 2021
@jwendell jwendell added the release-notes-none Indicates a PR that does not require release notes. label Jul 12, 2021
@jwendell jwendell force-pushed the bump-go-control-plane branch from d8678c1 to 939e080 Compare July 12, 2021 17:10
@jwendell jwendell requested review from a team as code owners July 12, 2021 17:10
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2021
@@ -765,8 +765,8 @@ func TestFilterChainMatchFields(t *testing.T) {
fcm := listener.FilterChainMatch{}
e := reflect.ValueOf(&fcm).Elem()
// If this fails, that means new fields have been added to FilterChainMatch, filterChainMatchEqual function needs to be updated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good test 👍

@jwendell jwendell force-pushed the bump-go-control-plane branch from 939e080 to 8a2be91 Compare July 12, 2021 17:31
@jwendell jwendell requested a review from a team as a code owner July 12, 2021 17:31
@jwendell jwendell mentioned this pull request Jul 12, 2021
58 tasks
Copy link
Contributor

@therealmitchconnors therealmitchconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good from UX (no code change, just comments for linter)

@jwendell
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit 867e88e into istio:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants