Skip to content

Bump dependencies #33974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Bump dependencies #33974

merged 1 commit into from
Jul 14, 2021

Conversation

jwendell
Copy link
Member

No description provided.

@jwendell jwendell requested review from costinm, howardjohn, linsun, nmittler and a team as code owners July 12, 2021 16:00
@istio-policy-bot
Copy link

😊 Welcome @jwendell! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 12, 2021
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2021
@jwendell jwendell added the release-notes-none Indicates a PR that does not require release notes. label Jul 12, 2021
ericvn
ericvn approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm curious if the proxy change will actually pass the current tests.

howardjohn
howardjohn approved these changes Jul 12, 2021
View reviewed changes
docker/Dockerfile.distroless
@@ -8,13 +8,13 @@ FROM ubuntu:focal as ubuntu_source
COPY --from=distroless_source /etc/ /home/etc
COPY --from=distroless_source /home/nonroot /home/nonroot
RUN echo istio-proxy:x:1337: >> /home/etc/group
RUN echo isito-proxy:x:1337:1337:istio-proxy:/nonexistent:/sbin/nologin >> /home/etc/passwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is suspicious.. I wonder how it worked properly before?

@jwendell
Copy link
Member Author

LGTM, but I'm curious if the proxy change will actually pass the current tests.

You're right. Should we skip proxy changes in this PR and let automator do its job when istio/proxy#3395 is merged?

This was referenced Jul 12, 2021
Closed
Closed
@jwendell jwendell mentioned this pull request Jul 12, 2021
Closed
@jwendell
Copy link
Member Author

/retest

2 similar comments
@jwendell
Copy link
Member Author

/retest

@jwendell
Copy link
Member Author

/retest

@bianpengyuan
Copy link
Contributor

bianpengyuan commented Jul 13, 2021 •
edited
Loading

Looks like there is proxy crashes: https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/33974/integ-cni-k8s-tests_istio/1414772690526408704. An upstream fix was just merged, which fixed a crash in the same function. envoyproxy/envoy#17302

@bianpengyuan
Copy link
Contributor

/retest

@jwendell jwendell mentioned this pull request Jul 13, 2021
Merged
@jwendell
Copy link
Member Author

/retest

@bianpengyuan
Copy link
Contributor

Looks another crashes caused by the same change..: envoyproxy/envoy#16948 (comment)

@jwendell jwendell mentioned this pull request Jul 13, 2021
Closed
@jwendell jwendell requested a review from a team as a code owner July 13, 2021 21:03
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2021
@bianpengyuan
Copy link
Contributor

Hmm still does not work. They are reverting envoyproxy/envoy#16948, so let's wait for that.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2021
@istio-testing istio-testing merged commit 1f3c358 into istio:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@ericvn ericvn ericvn approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@nmittler nmittler Awaiting requested review from nmittler

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwendell @istio-policy-bot @bianpengyuan @howardjohn @ericvn @istio-testing