make installation error details become more clear when building kubernetes client #33587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have done 2 test cases in my environment as below: With wrong value of KUBECONFIG: With wrong information inside config file of KUBECONFIG: |
howardjohn
reviewed
Jun 23, 2021
howardjohn
reviewed
Jun 23, 2021
|
/test unit-tests_istio |
howardjohn
reviewed
Jun 28, 2021
operator/cmd/mesh/install.go
Outdated
Comment on lines
137
to
138
| operation := "encounter error when creating Kubernetes client, error detail" | ||
| return wrapErrorf(operation, err) |
There was a problem hiding this comment.
Suggested change
| operation := "encounter error when creating Kubernetes client, error detail" | |
| return wrapErrorf(operation, err) | |
| return fmt.Errorf("create Kubernetes client: %v", err) |
This follows standard patterns in the rest of the code base. When creating errors like this, we get useful messages as errors propogate up, like installation failed: create Kubernetes client: permission denied or similar
There was a problem hiding this comment.
similar comment applies to the rest
There was a problem hiding this comment.
@howardjohn the code style is the same now. ^_^
howardjohn
approved these changes
Jun 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make installation error details become more clear when building kubernetes client based on issue#33402
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.