Add DeploymentConflictingPorts analyzer #30049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test integ-telemetry-mc-k8s-tests_istio |
…service-conflicting-ports
esnible
reviewed
Jan 15, 2021
| - name: "DeploymentConflictingPorts" | ||
| code: IST0137 | ||
| level: Warning | ||
| description: "If we have two services, both selecting the same workload, with the same target port, they should be the same port." |
There was a problem hiding this comment.
Reword without "if"? Perhaps "Two services selecting the same workload with same target port are MUST refer to the same port."
| code: IST0137 | ||
| level: Warning | ||
| description: "If we have two services, both selecting the same workload, with the same target port, they should be the same port." | ||
| template: "This deployment %s is associated with multiple services %v using targetPort %s but different ports: %v." |
There was a problem hiding this comment.
Nit: use %q instead of %s if port name can be empty.
|
@esnible Thanks, updated. |
|
@esnible Do i need to do something else? |
esnible
approved these changes
Jan 22, 2021
|
/retest |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29302
[X] User Experience
[X] Developer Infrastructure
[X] Does not have any changes that may affect Istio users.