Fix the setup script for VMs, add back to pilot port for upgrades #2820
Conversation
|
Note that the .deb in the latest daily I tried is out of sync with the makefile ( or something is really wrong in the build ) - I get only a subset of the files. /usr/local/bin/istio-start.sh while the daily build /usr/local/bin/istio-start.sh |
| curl -f -L ${AUTH_DEBIAN_URL}/istio-auth-node-agent.deb > ${ISTIO_STAGING}/istio-auth-node-agent.deb | ||
| curl -f -L ${PROXY_DEBIAN_URL}/istio-proxy.deb > ${ISTIO_STAGING}/istio-proxy.deb | ||
| rm -f istio-sidecar.deb | ||
| echo curl -f -L ${PILOT_DEBIAN_URL}/istio-sidecar.deb > ${ISTIO_STAGING}/istio-sidecar.deb |
There was a problem hiding this comment.
Well, I needed it - since it was not clear what the curl was doing. I don't think it hurts, but it may help. The actual file it attempts to download doesn't actually work, I had to manually patch the version file.
|
seems it can only get better from there (once the referenced url contains good stuff) /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@costinm could you clarify the .deb build problem? Do you see that in the daily pre-release or some other daily build? @mattdelco verified that the image built by the official release seemed to be fine (that ./usr/local/bin/istio-iptables.sh existed.) |
|
I picked the last daily build - I'll double check I got the right URL, had to patch it. Where is the current pre-release ? Will try again in the morning. |
|
/retest |
|
To be more explicit, I opened the deb using emacs and data.tar.gz showed (in part) the following (in particular the line for istio-iptables.sh): -rwxr-xr-x 0/0 34197578 ./usr/local/bin/node_agent -rwxr-xr-x 0/0 41340315 ./usr/local/bin/istioctl -rwxr-xr-x 0/0 3030 ./usr/local/bin/istio-start.sh -rwxr-xr-x 0/0 190920624 ./usr/local/bin/envoy -rwxr-xr-x 0/0 44399283 ./usr/local/bin/pilot-discovery -rwxr-xr-x 0/0 6639 ./usr/local/bin/istio-iptables.sh -rwxr-xr-x 0/0 50666783 ./usr/local/bin/mixs -rwxr-xr-x 0/0 18464855 ./usr/local/bin/pilot-agent -rwxr-xr-x 0/0 39491845 ./usr/local/bin/istio_ca |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
| curl -f -L ${AUTH_DEBIAN_URL}/istio-auth-node-agent.deb > ${ISTIO_STAGING}/istio-auth-node-agent.deb | ||
| curl -f -L ${PROXY_DEBIAN_URL}/istio-proxy.deb > ${ISTIO_STAGING}/istio-proxy.deb | ||
| rm -f istio-sidecar.deb | ||
| echo curl -f -L ${PILOT_DEBIAN_URL}/istio-sidecar.deb > ${ISTIO_STAGING}/istio-sidecar.deb |
There was a problem hiding this comment.
the "" are missing... the echo goes to istio-sidecar.deb !
First part matches the new distribution (single debian file).
The second is useful for cases where istio apps using older versions of pods (which were attempting to use port 8080). Also we will need to adjust 15003 to use mTLS, to allow gradual adoption of auth (i.e. a mix of auth and no-auth ), in which case we need to keep using 8080.