do not update root certs for destination rule certs #27268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
@howardjohn see if this fixes #27218 or will it have any side affects? |
|
I don't think this fixes the problem, though I haven't tried yet. @ramaraochavali could you verify? |
|
I do not have the setup to validate this right now - But based on what @howardjohn found, I expect this to fix because the DR root cert are not being updated secret cache. If not, I will take a look later. |
howardjohn
approved these changes
Sep 14, 2020
yskopets
pushed a commit
to yskopets/istio
that referenced
this pull request
Oct 26, 2020
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
pushed a commit
that referenced
this pull request
Nov 4, 2020
sel-vcc
pushed a commit
to sel-vcc/istio
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Rama Chavali <rama.rao@salesforce.com> (cherry picked from commit 2cbbf53)
istio-testing
pushed a commit
that referenced
this pull request
Nov 17, 2020
…ule certs (#27268) (#28869) * do not update root certs for destination rule certs (#27268) Signed-off-by: Rama Chavali <rama.rao@salesforce.com> (cherry picked from commit 2cbbf53) * common/scripts: Fix quoting Quoting was causing CI lint check to fail: https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/28869/lint_istio_release-1.6/1328742716099530752/build-log.txt Signed-off-by: Steve Larkin <steve.larkin+vcc@gmail.com> Co-authored-by: Rama Chavali <rama.rao@salesforce.com>
vikaschoudhary16
pushed a commit
to vikaschoudhary16/istio
that referenced
this pull request
Feb 12, 2021
…tio#147) Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #27218
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.