-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Change deprecated Cobra method SetOutput
(#25083)
#25084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change deprecated Cobra method SetOutput
(#25083)
#25084
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @piotrkpc. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
/ok-to-test |
*cobra.Command `SetOutput` method is deprecated [0]. Replacing with `SetOut` and `SetErr`. [0]: spf13/cobra#822
494c7b4
to
4fadba7
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
*cobra.Command
SetOutput
method is deprecated 0. Replacingwith
SetOut
andSetErr
1 should help in future.Fixes #25083