Skip to content

Incorporate API changes in SIdecar resource #25585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Incorporate API changes in SIdecar resource #25585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0559e40
Incorporate API changes in SIdecar resource
Jul 16, 2020
02e442d
Make gen
Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions galley/pkg/config/analysis/analyzers/analyzers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ var testGrid = []testCase{
expected: []message{
{msg.Deprecated, "VirtualService productpage.foo"},
{msg.Deprecated, "Sidecar no-selector.default"},
{msg.Deprecated, "Sidecar no-selector.default"},
{msg.Deprecated, "Sidecar no-selector.default"},
{msg.Deprecated, "Sidecar no-selector.default"},
},
},
{
Expand Down
23 changes: 0 additions & 23 deletions galley/pkg/config/analysis/analyzers/deprecation/deprecation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,29 +60,6 @@ func (*FieldAnalyzer) analyzeSidecar(r *resource.Instance, ctx analysis.Context)

sc := r.Message.(*v1alpha3.Sidecar)

if sc.Localhost != nil {
ctx.Report(collections.IstioNetworkingV1Alpha3Virtualservices.Name(),
msg.NewDeprecated(r, ignoredMessage("Localhost")))
}

for _, ingress := range sc.Ingress {
if ingress != nil {
if ingress.LocalhostClientTls != nil {
ctx.Report(collections.IstioNetworkingV1Alpha3Virtualservices.Name(),
msg.NewDeprecated(r, ignoredMessage("Ingress.LocalhostClientTLS")))
}
}
}

for _, egress := range sc.Egress {
if egress != nil {
if egress.LocalhostServerTls != nil {
ctx.Report(collections.IstioNetworkingV1Alpha3Virtualservices.Name(),
msg.NewDeprecated(r, ignoredMessage("Egress.LocalhostServerTLS")))
}
}
}

if sc.OutboundTrafficPolicy != nil {
if sc.OutboundTrafficPolicy.EgressProxy != nil {
ctx.Report(collections.IstioNetworkingV1Alpha3Virtualservices.Name(),
Expand Down
6 changes: 0 additions & 6 deletions galley/pkg/config/analysis/analyzers/testdata/deprecation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,13 @@ spec:
ingress:
- port:
number: 9080
localhostClientTls:
mode: SIMPLE
defaultEndpoint: unix:///var/run/some.sock
egress:
- hosts:
- "./*"
localhostServerTls:
mode: SIMPLE
outboundTrafficPolicy:
mode: ALLOW_ANY
egressProxy:
host: example
port:
number: 9080
localhost:
clientTls:
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ require (
gopkg.in/square/go-jose.v2 v2.3.1
gopkg.in/yaml.v2 v2.3.0
helm.sh/helm/v3 v3.2.4
istio.io/api v0.0.0-20200714164416-42acf9095d43
istio.io/api v0.0.0-20200716183019-c358dad98012
istio.io/client-go v0.0.0-20200626204548-8f69a2d0fe26
istio.io/gogo-genproto v0.0.0-20200422223746-8166b73efbae
istio.io/pkg v0.0.0-20200504224939-261164cc57da
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,8 +1093,8 @@ honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt
istio.io/api v0.0.0-20190515205759-982e5c3888c6/go.mod h1:hhLFQmpHia8zgaM37vb2ml9iS5NfNfqZGRt1pS9aVEo=
istio.io/api v0.0.0-20200626203124-c07d1d63dab7 h1:7EruC/H7vE0Zwe8NnekcH7e6O6x3MKL99scZlJZd+YE=
istio.io/api v0.0.0-20200626203124-c07d1d63dab7/go.mod h1:88HN3o1fSD1jo+Z1WTLlJfMm9biopur6Ct9BFKjiB64=
istio.io/api v0.0.0-20200714164416-42acf9095d43 h1:d8kyjro1o82Ivhpr6ESTcYG4s89hT49AM7kyxGXCOSw=
istio.io/api v0.0.0-20200714164416-42acf9095d43/go.mod h1:88HN3o1fSD1jo+Z1WTLlJfMm9biopur6Ct9BFKjiB64=
istio.io/api v0.0.0-20200716183019-c358dad98012 h1:n0/RUbgwGBraOKX9FRnWU4bSi2+hOwNz3d9Ampm3JjQ=
istio.io/api v0.0.0-20200716183019-c358dad98012/go.mod h1:88HN3o1fSD1jo+Z1WTLlJfMm9biopur6Ct9BFKjiB64=
istio.io/client-go v0.0.0-20200626204548-8f69a2d0fe26 h1:XLTmjndquXukwZVU9G6c3d/2ew43te4SuMap8UTP1R4=
istio.io/client-go v0.0.0-20200626204548-8f69a2d0fe26/go.mod h1:OQTGBgFbgNzUMafgS5LExTTMQAA+JeC6d0m1Tphi2dk=
istio.io/gogo-genproto v0.0.0-20190930162913-45029607206a/go.mod h1:OzpAts7jljZceG4Vqi5/zXy/pOg1b209T3jb7Nv5wIs=
Expand Down
Loading