Activate VM expansion test #2444

chxchx · 2018-01-05T18:03:16Z

No description provided.

chxchx · 2018-01-05T20:24:13Z

Given the recent go native tooling migration. VM tests are failing due to: (ssh on the VM)

dpkg: error processing archive ./istio-agent.deb (--install):
 subprocess dpkg-deb --control returned error exit status 2
Errors were encountered while processing:
 ./istio-agent.deb
dpkg-deb: error: './istio-auth-node-agent.deb' is not a debian format archive

The reason is likely that debian pkg was not built and pushed due to postsubmit failure. Trying retest.

ldemailly · 2018-01-06T22:21:47Z

yeah we really need to check automatically at least nightly as it got broken in 0.3.0 with istio on istio and probably also yes with the build changes

chxchx · 2018-01-09T19:58:12Z

Per #2220 the debs are not being built at the moment. There is also going ot be only one deb instead of three. @costinm Do you have an ETA on when building debs with fpm and an update to https://github.com/istio/istio/blob/master/install/tools/setupIstioVM.sh will be made?

mattdelco · 2018-01-30T19:12:26Z

Per #2960 it seems like e2e-suite.sh ignores its command-line args so I don't see how this PR has any effect.

istio-merge-robot · 2018-02-02T08:01:44Z

@chxchx PR needs rebase

chxchx · 2018-02-06T20:49:28Z

:(

I0206 00:28:35.203] *** Fetching istio packages...
I0206 00:28:35.203]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
I0206 00:28:35.203]                                  Dload  Upload   Total   Spent    Left  Speed
I0206 00:28:35.203] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
I0206 00:28:35.203] curl: (22) The requested URL returned error: 404 
I0206 00:28:35.204] dpkg-deb: error: './istio-sidecar.deb' is not a debian format archive
I0206 00:28:35.204] dpkg: error processing archive ./istio-sidecar.deb (--install):
I0206 00:28:35.204]  subprocess dpkg-deb --control returned error exit status 2
I0206 00:28:35.204] Errors were encountered while processing:
I0206 00:28:35.204]  ./istio-sidecar.deb

When is ./istio-sidecar.deb going to be ready? @costinm @ldemailly

istio-merge-robot · 2018-02-06T20:50:05Z

@chxchx PR needs rebase

mattdelco · 2018-02-06T21:31:27Z

The deb is ready (and shipped in 0.5.0) but it's not hooked up to "make push". The following might do the trick:

https://github.com/istio/istio/compare/master...mattdelco:master15?expand=1

googlebot · 2018-02-07T18:51:22Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

chxchx · 2018-02-14T23:28:23Z

In latest commit (hopefully the last one) I added retries to ensure firewall is still up so ssh/scp is permitted to the VM. PTAL

ldemailly · 2018-02-15T06:22:35Z

the project should have our mdb as owner so it doesn't get firewall enforced?

chxchx · 2018-02-15T20:59:23Z

I am not sure why firewall rules are deleted after certain period. The reenforcement of the firewall is a workaround to this problem. With integration with Seb's cluster preprovisioning tool, this problem should go away as resources are recycled on a project base.

ldemailly · 2018-02-15T23:53:26Z

/lgtm
(assuming it works etc)

costinm · 2018-02-15T23:58:46Z

tests/istio.mk

@@ -79,7 +79,7 @@ e2e_mixer: istioctl generate_yaml
 	go test -v -timeout 20m ./tests/e2e/tests/mixer -args ${E2E_ARGS} ${EXTRA_E2E_ARGS}

 e2e_bookinfo: istioctl generate_yaml
-	go test -v -timeout 20m ./tests/e2e/tests/bookinfo -args ${E2E_ARGS} ${EXTRA_E2E_ARGS}
+	go test -v -timeout 60m ./tests/e2e/tests/bookinfo -args ${E2E_ARGS} ${EXTRA_E2E_ARGS}


Does it take 60 min to run bookinfo ?

Can we move only the vm test to separate target if it's that long, so it runs in parallel ?

istio-merge-robot · 2018-02-16T00:11:23Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2018-02-16T00:39:47Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @chxchx @ldemailly

chxchx · 2018-02-16T00:41:24Z

Per discussion with @hklai I am moving the VM extension test to postsubmit not to add to much overhead on already lengthy presubmit.

hklai · 2018-02-16T00:43:14Z

Right. That is the plan for now and we will re-evaluate after we get more data about stability and exec time of these tests.

…

On Thu, Feb 15, 2018 at 4:41 PM, Charles Xu ***@***.***> wrote: Per discussion with @hklai <https://github.com/hklai> I am moving the VM extension test to postsubmit not to add to much overhead on already lengthy presubmit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2444 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeRtkGBvQNRL_8SfJRZVgPIKb8g7o755ks5tVM68gaJpZM4RUwnl> .

yutongz · 2018-02-16T02:50:53Z

/test e2e-simple
/test e2e-bookInfo

We renamed e2e-smoke to e2e-bookInfo and added e2e-simple
ref: #3529

istio-testing · 2018-02-16T03:03:32Z

@chxchx: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/e2e-smoke.sh	`72ccf61`	link	`/test e2e-smoke`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yutongz · 2018-02-16T22:55:43Z

/lgtm

istio-merge-robot · 2018-02-16T22:56:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly, yutongz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

istio-merge-robot · 2018-02-16T23:18:29Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2018-02-16T23:43:34Z

Automatic merge from submit-queue.

yutongz · 2018-02-17T09:25:48Z

This PR broke e2e-suite-cluster_wide test in Postsubmit, if we can't figure out the issue, we probably should revert it.

Automatic merge from submit-queue. Install fpm in prowbazel and istio-builder images Trying to fix istio/istio#3279 which eventually will fix istio/istio#2444

googlebot added the cla: yes label Jan 5, 2018

ldemailly added area/environments automated-release labels Jan 6, 2018

chxchx mentioned this pull request Jan 8, 2018

debian pkgs not uploaded to istio-artifacts on gcs in postsubmit #2473

Closed

chxchx force-pushed the testvmjob branch from 45e4585 to d98dc7a Compare January 30, 2018 18:54

chxchx requested a review from a team January 30, 2018 18:54

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 2, 2018

chxchx force-pushed the testvmjob branch from d98dc7a to 333ba47 Compare February 2, 2018 19:14

istio-merge-robot removed the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 2, 2018

chxchx mentioned this pull request Feb 2, 2018

Ensure command line flags are passed through #3116

Merged

chxchx force-pushed the testvmjob branch 2 times, most recently from 82378ae to 1a76ad0 Compare February 5, 2018 21:08

chxchx requested a review from a team February 5, 2018 23:06

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 6, 2018

chxchx force-pushed the testvmjob branch from 6ac60f9 to 6fd89bf Compare February 7, 2018 18:51

chxchx requested review from costinm and ldemailly as code owners February 7, 2018 18:51

chxchx requested review from a team February 7, 2018 18:51

googlebot removed the cla: yes label Feb 7, 2018

istio-merge-robot removed the lgtm label Feb 14, 2018

ensure access to VM remains

72ccf61

chxchx force-pushed the testvmjob branch from 8b740db to 72ccf61 Compare February 14, 2018 21:10

istio-testing added the lgtm label Feb 15, 2018

costinm reviewed Feb 15, 2018

View reviewed changes

costinm approved these changes Feb 15, 2018

View reviewed changes

move vm extension test to postsubmit

e30a018

istio-merge-robot removed the lgtm label Feb 16, 2018

chxchx force-pushed the testvmjob branch from 086f46d to e30a018 Compare February 16, 2018 00:59

Merge remote-tracking branch 'istio/master' into testvmjob

7a610d7

istio-testing assigned yutongz Feb 16, 2018

istio-testing added the lgtm label Feb 16, 2018

istio-merge-robot merged commit 0b07654 into istio:master Feb 16, 2018

Activate VM expansion test #2444

Activate VM expansion test #2444

Uh oh!

Conversation

chxchx commented Jan 5, 2018

Uh oh!

chxchx commented Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Jan 6, 2018

Uh oh!

chxchx commented Jan 9, 2018

Uh oh!

mattdelco commented Jan 30, 2018

Uh oh!

istio-merge-robot commented Feb 2, 2018

Uh oh!

chxchx commented Feb 6, 2018

Uh oh!

istio-merge-robot commented Feb 6, 2018

Uh oh!

mattdelco commented Feb 6, 2018

Uh oh!

googlebot commented Feb 7, 2018

Uh oh!

chxchx commented Feb 14, 2018

Uh oh!

ldemailly commented Feb 15, 2018

Uh oh!

chxchx commented Feb 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Feb 15, 2018

Uh oh!

costinm Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

istio-merge-robot commented Feb 16, 2018

Uh oh!

istio-merge-robot commented Feb 16, 2018

Uh oh!

chxchx commented Feb 16, 2018

Uh oh!

hklai commented Feb 16, 2018 via email

Uh oh!

yutongz commented Feb 16, 2018

Uh oh!

istio-testing commented Feb 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yutongz commented Feb 16, 2018

Uh oh!

istio-merge-robot commented Feb 16, 2018

Uh oh!

istio-merge-robot commented Feb 16, 2018

Uh oh!

istio-merge-robot commented Feb 16, 2018

Uh oh!

yutongz commented Feb 17, 2018

Uh oh!

Uh oh!

chxchx commented Jan 5, 2018 •

edited

Loading

chxchx commented Feb 15, 2018 •

edited

Loading

istio-testing commented Feb 16, 2018 •

edited

Loading