Skip to content

Conversation

nmittler
Copy link
Contributor

@nmittler nmittler commented Jan 2, 2018

Fix BUILD files broken by #2240

@nmittler nmittler requested a review from mattdelco January 2, 2018 23:02
@nmittler nmittler mentioned this pull request Jan 2, 2018
@nmittler nmittler changed the title Fix BUILD files broken by #2240 Fix BUILD files Jan 2, 2018
Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mattdelco
Copy link
Contributor

Looks fine to me, though if #2370 gets in first then it'll make this moot.

@ZackButcher ZackButcher requested a review from geeknoid January 2, 2018 23:10
Copy link
Contributor

@geeknoid geeknoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, ZackButcher

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants