Skip to content

[release-1.5] Build: Honor GOBUILDFLAGS variable also in test mode #22172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2020
Merged

[release-1.5] Build: Honor GOBUILDFLAGS variable also in test mode #22172

merged 1 commit into from
Mar 14, 2020

Conversation

jwendell
Copy link
Member

We already honor it in go build, we should do the same
in go test.

Manual backport of #22163

@jwendell
[release-1.5] Build: Honor GOBUILDFLAGS variable also in test mode
57a9e38 
We already honor it in `go build`, we should do the same
in `go test`.

Manual backport of istio#22163
@jwendell jwendell requested a review from a team March 13, 2020 20:56
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 13, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2020
@istio-testing istio-testing merged commit 9be91c3 into istio:release-1.5 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@johnma14 johnma14 johnma14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwendell @johnma14 @googlebot @istio-testing