remove use_downstream_protocol for gateway #21247
Conversation
|
/retest |
| @@ -1249,8 +1249,8 @@ func setUpstreamProtocol(node *model.Proxy, cluster *apiv2.Cluster, port *model. | |||
| } | |||
| } | |||
|
|
|||
| if (util.IsProtocolSniffingEnabledForInboundPort(node, port) && direction == model.TrafficDirectionInbound) || | |||
| (util.IsProtocolSniffingEnabledForOutboundPort(node, port) && direction == model.TrafficDirectionOutbound) { | |||
| if node.Type == model.SidecarProxy && ((util.IsProtocolSniffingEnabledForInboundPort(node, port) && direction == model.TrafficDirectionInbound) || | |||
There was a problem hiding this comment.
looks good, better add some comments
There was a problem hiding this comment.
Can you please explain in comments, why enabling it for gateways is a problem so that it is more clear on why we are adding only for sidecar?
There was a problem hiding this comment.
Thanks for adding the comments, looks good
* remove use_downstream_protocol for gateway * comment * writing
|
/cherrypick release-1.5 |
|
@howardjohn: new pull request created: #21726 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.4 |
|
@howardjohn: new pull request created: #21727 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes #21230