Skip to content

[release-1.5] listener: handle nil pilot metakey #21570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

[release-1.5] listener: handle nil pilot metakey #21570

merged 1 commit into from
Feb 27, 2020

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #21513

@ramaraochavali @istio-testing
handle nil pilot metakey
ef4b986 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@istio-testing istio-testing requested a review from a team February 27, 2020 03:22
@istio-testing istio-testing mentioned this pull request Feb 27, 2020
Merged
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Feb 27, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2020
@ramaraochavali
Copy link
Contributor

@googlebot I consent

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Feb 27, 2020
@ramaraochavali
Copy link
Contributor

@howardjohn Can you PTAL? this is for 1.5

@dgn
Copy link
Contributor

dgn commented Feb 27, 2020

/retest

@istio-testing istio-testing merged commit e45aa9f into istio:release-1.5 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgn dgn dgn approved these changes

Assignees

@ramaraochavali ramaraochavali

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@istio-testing @googlebot @ramaraochavali @dgn