listener: handle nil pilot metakey #21513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
jwendell
approved these changes
Feb 26, 2020
howardjohn
approved these changes
Feb 26, 2020
| @@ -2652,8 +2652,8 @@ func isMatchAllFilterChain(fc *listener.FilterChain) bool { | |||
|
|
|||
| func isFallthroughFilterChain(fc *listener.FilterChain) bool { | |||
| if fc.Metadata != nil && fc.Metadata.FilterMetadata != nil && | |||
| fc.Metadata.FilterMetadata[PilotMetaKey].Fields["fallthrough"].GetBoolValue() { | |||
There was a problem hiding this comment.
This could be fc.Metadata.FilterMetadata[PilotMetaKey].GetFields()["fallthrough"].GetBoolValue() { I think since gogo does nil checks
|
/cherrypick/release-1.5 |
|
In response to a cherrypick label: new pull request created: #21570 |
|
Hi, @ramaraochavali is this going to be backported to 1.4 ? |
|
@pmoncadaisla It is already backported to 1.4 via this #21514 |
|
Hi @ramaraochavali, it was merged in |
|
I see. @howardjohn Do you know when |
|
This week
…On Mon, Mar 23, 2020, 3:01 AM Rama Chavali ***@***.***> wrote:
I see. @howardjohn <https://github.com/howardjohn> Do you know when 1.4.7
will be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21513 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXPUCLXAI57J54OZEPTRI4XRHANCNFSM4K4G7SSQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21508
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure