Skip to content

Example DNS certificate configuration for istio.io user guide #17867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

Example DNS certificate configuration for istio.io user guide #17867

merged 1 commit into from
Oct 15, 2019

Conversation

lei-tang
Copy link
Contributor

Please provide a description for what this PR is for: this PR adds an example DNS certificate configuration for the istio.io user guide in istio/istio.io#5152.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@lei-tang lei-tang requested a review from a team as a code owner October 14, 2019 21:14
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 14, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2019
@lei-tang lei-tang mentioned this pull request Oct 14, 2019
Merged
@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label Oct 14, 2019
howardjohn
howardjohn approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you can remove hold once the docs PR lands

@lei-tang
Copy link
Contributor Author

Since istio/istio.io#5152 depends on this PR, this PR should be merged before istio/istio.io#5152. Without this PR, the PR 5152 will fail at link check:

So the hold on this PR is removed.

@lei-tang lei-tang removed the do-not-merge/hold Block automatic merging of a PR. label Oct 14, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2019
@lei-tang lei-tang force-pushed the example-dns-helm-value branch from 79233f9 to af1a682 Compare October 15, 2019 00:04
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2019
@lei-tang lei-tang added do-not-merge/hold Block automatic merging of a PR. and removed do-not-merge/hold Block automatic merging of a PR. labels Oct 15, 2019
@lei-tang
Copy link
Contributor Author

/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

@lei-tang lei-tang mentioned this pull request Oct 15, 2019
Merged
@lei-tang
Copy link
Contributor Author

/test integ-security-k8s-tests_istio

@istio-testing istio-testing merged commit cee3fed into istio:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lei-tang @howardjohn @googlebot @istio-testing