Skip to content

Conversation

rshriram
Copy link
Member

@rshriram rshriram commented Feb 22, 2017

This change is Reviewable

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Feb 22, 2017
@rshriram
Copy link
Member Author

closing.. @frankbu will create it again

@rshriram rshriram closed this Feb 22, 2017
@frankbu frankbu deleted the bookinfo_demo branch February 22, 2017 19:39
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* Add cert generation lib and tool.

* pass signer key/cert by reference

* update comments

* Update comment
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
* Add cert generation lib and tool.

* pass signer key/cert by reference

* update comments

* Update comment
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
vikaschoudhary16 pushed a commit to vikaschoudhary16/istio that referenced this pull request Oct 11, 2019
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Mar 27, 2020
istio-testing pushed a commit that referenced this pull request Mar 27, 2020
* Create a random signing_key for kiali and bump to v1.15 (#15)

* [kiali] [release-1.5] update default profile to kiali v1.15 (#18)

* Run make gen

Co-authored-by: John Mazzitelli <mazz@redhat.com>
istio-testing pushed a commit that referenced this pull request Mar 27, 2020
* Create a random signing_key for kiali and bump to v1.15 (#15)

* [kiali] [release-1.5] update default profile to kiali v1.15 (#18)

* make gen

* make gen

* make gen

* Revert "make gen"

This reverts commit c3824a8.

* Revert "make gen"

This reverts commit fb49813.

* Revert "make gen"

This reverts commit 702025d.

* re-try

Co-authored-by: John Mazzitelli <mazz@redhat.com>
danehans pushed a commit to danehans/istio that referenced this pull request Nov 2, 2021
@LugiaChang LugiaChang mentioned this pull request Sep 19, 2022
16 tasks
@pavan359t pavan359t mentioned this pull request Sep 6, 2024
2 tasks
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
…stio#15)

* Changes to report junit file and results from the running test suite

set prow by default to true

Fix error on ocp script

Adding some fixes and debug information

Fix variable declaration of JUNIT_REPORT

Fix junit report declaration

Fix artifacts dir

Testing new changes

Fix position of the skip test flag

Check if artificats dir env var is defined

Refactor and add helm flag

* Improve the ocp test script from review

* Changes from review
johnlanni added a commit to johnlanni/istio that referenced this pull request Dec 26, 2024
fix: Fix the apt repo not signed error during building process
dgn pushed a commit to dgn/istio that referenced this pull request Jun 24, 2025
…stio#15)

* Changes to report junit file and results from the running test suite

set prow by default to true

Fix error on ocp script

Adding some fixes and debug information

Fix variable declaration of JUNIT_REPORT

Fix junit report declaration

Fix artifacts dir

Testing new changes

Fix position of the skip test flag

Check if artificats dir env var is defined

Refactor and add helm flag

* Improve the ocp test script from review

* Changes from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants