Skip to content

Add CRD AuthorizationPolicy for authorization v2 API #12318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2019
Merged

Add CRD AuthorizationPolicy for authorization v2 API #12318

merged 3 commits into from
Mar 14, 2019

Conversation

yangminzhu
Copy link
Contributor

This would eventually deprecate the current ServiceRoleBinding.

See more: https://docs.google.com/document/d/1diwa9oYVwmLtarXb-kfWPq-Ul3O2Ic3b8Y21Z3R8DzQ/edit#heading=h.x9snb54sjlu9

@yangminzhu yangminzhu added this to the 1.2 milestone Mar 7, 2019
@yangminzhu yangminzhu requested review from pitlv2109 and liminw March 7, 2019 02:39
golangcibot
golangcibot reviewed Mar 7, 2019
View reviewed changes
@yangminzhu
Copy link
Contributor Author

This PR is ready for review, @rshriram @ozevren Could you review the change to Pilot and Galley. Thanks!

@yangminzhu yangminzhu mentioned this pull request Mar 11, 2019
Closed
21 tasks
@ozevren
Copy link
Contributor

ozevren commented Mar 12, 2019

/lgtm
Galley changes lgtm

rshriram
rshriram approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ozevren, rshriram, yangminzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 00d408e into istio:master Mar 14, 2019
@istio-testing
Copy link
Collaborator

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh c63f66d link /test istio-integ-k8s-tests
prow/e2e-simpleTests-cni.sh c63f66d link /test e2e-simpleTests-cni
prow/istio-pilot-multicluster-e2e.sh c63f66d link /test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu yangminzhu deleted the authzPolicy branch March 15, 2019 00:46
@yangminzhu
Copy link
Contributor Author

For #12394

This was referenced Mar 15, 2019
Merged
Merged
@rlenglet rlenglet modified the milestones: 1.4, 1.3 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitlv2109 pitlv2109 Awaiting requested review from pitlv2109

@liminw liminw Awaiting requested review from liminw

@ozevren ozevren Awaiting requested review from ozevren

2 more reviewers

@golangcibot golangcibot golangcibot left review comments

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ozevren ozevren

Labels
area/security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yangminzhu @ozevren @istio-testing @rshriram @golangcibot @rlenglet @googlebot