Skip to content

rbac: support authorization policy on gateway #12415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2019
Merged

rbac: support authorization policy on gateway #12415

merged 3 commits into from
Mar 17, 2019

Conversation

yangminzhu
Copy link
Contributor

@yangminzhu yangminzhu commented Mar 12, 2019 •
edited
Loading

Same as #11894 but with e2e tests. Also tested manually on ingress-gateway.

For #12394

@yangminzhu yangminzhu added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 12, 2019
golangcibot
golangcibot reviewed Mar 12, 2019
View reviewed changes
@yangminzhu yangminzhu force-pushed the rbac-gw branch 3 times, most recently from f1304e2 to c16704e Compare March 12, 2019 05:54
@yangminzhu yangminzhu changed the title [WIP] rbac: support gateway rbac: support gateway Mar 12, 2019
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 12, 2019
@yangminzhu yangminzhu mentioned this pull request Mar 12, 2019
Closed
@yangminzhu yangminzhu force-pushed the rbac-gw branch 2 times, most recently from ed06b58 to 2b77a95 Compare March 12, 2019 18:38
@yangminzhu yangminzhu changed the title rbac: support gateway rbac: support authorization policy on gateway Mar 12, 2019
diemtvu
diemtvu reviewed Mar 12, 2019
View reviewed changes
@yangminzhu yangminzhu added this to the 1.2 milestone Mar 15, 2019
@yangminzhu yangminzhu mentioned this pull request Mar 15, 2019
Closed
21 tasks
@yangminzhu
Copy link
Contributor Author

@diemtvu @rshriram All tests passed, ready for review, thanks.

@yangminzhu yangminzhu mentioned this pull request Mar 15, 2019
Closed
rshriram
rshriram approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangminzhu
Copy link
Contributor Author

Adding /lgtm manually as the istio-testing failed to reply to @rshriram's reply #12415 (review)

@yangminzhu yangminzhu self-assigned this Mar 15, 2019
@yangminzhu
Copy link
Contributor Author

/lgtm

@istio-testing
Copy link
Collaborator

@yangminzhu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram
Copy link
Member

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rshriram, yangminzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh 364c613 link /test istio-integ-k8s-tests
prow/e2e-simpleTests-cni.sh 364c613 link /test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit a08434d into master Mar 17, 2019
@yangminzhu yangminzhu deleted the rbac-gw branch March 18, 2019 17:39
@rlenglet rlenglet modified the milestones: 1.4, 1.3 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@diemtvu diemtvu diemtvu left review comments

@golangcibot golangcibot golangcibot left review comments

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yangminzhu yangminzhu

Labels
area/security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yangminzhu @istio-testing @rshriram @diemtvu @golangcibot @rlenglet @googlebot