Mesh scripts: doc/typos/fixes/clarifications/simplifications #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```release-note Improvements to the mesh expansion / vm setup script ```
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
chxchx
reviewed
Oct 12, 2017
install/tools/setupMeshEx.sh
Outdated
| # ISTIO_STAGING - directory where istio artifacts are downloaded, default to current dir | ||
| # ISTIO_VERSION - istio version. | ||
| # ISTIO_NAMESPACE - defaults to istio-system, needs to be set for custom deployments | ||
| # ISTIO_STAGING - directory where istio artifacts are downloaded, default to |
There was a problem hiding this comment.
ISTIO_STAGING is no longer being used given this PR. Perhaps remove this line.
There was a problem hiding this comment.
thx ! still cleaning up as I go but good catch
This was referenced Oct 12, 2017
ldemailly
commented
Oct 13, 2017
| @@ -56,19 +73,6 @@ function istioInstall() { | |||
|
|
|||
| chown -R istio-proxy /etc/certs | |||
There was a problem hiding this comment.
package must be installed first so the istio-proxy user exists
ldemailly
commented
Oct 13, 2017
| # SERVICE_NAMESPACE- namespace where the service account and service are running. Defaults to | ||
| # the current workspace in kube config. | ||
|
|
||
| # GCLOUD_OPTS - optional parameters for gcloud command, for example "--project P --zone Z". |
costinm
approved these changes
Oct 13, 2017
ldemailly
added a commit
that referenced
this pull request
Oct 13, 2017
* Fix for wrong doc of env vars, clarifications, formatting ```release-note Improvements to the mesh expansion / vm setup script ``` * Drop dependency on ISTIO_VERSION, clarify secret prefix vs svc account * Show what we wait for, more cleanup * Removed mixer-server * More fixes - use urls from istio.VERSION; check for dnsmasq
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Fix for wrong doc of env vars, clarifications, formatting ```release-note Improvements to the mesh expansion / vm setup script ``` * Drop dependency on ISTIO_VERSION, clarify secret prefix vs svc account * Show what we wait for, more cleanup * Removed mixer-server * More fixes - use urls from istio.VERSION; check for dnsmasq Former-commit-id: 79a9916
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
) * Fix for wrong doc of env vars, clarifications, formatting ```release-note Improvements to the mesh expansion / vm setup script ``` * Drop dependency on ISTIO_VERSION, clarify secret prefix vs svc account * Show what we wait for, more cleanup * Removed mixer-server * More fixes - use urls from istio.VERSION; check for dnsmasq Former-commit-id: 79a9916
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
Automatic merge from submit-queue fix format of the local tag in bin/push-docker The current local tag format is `$(whoami)_$(date +%y%m%d_%h%m%s)`. It seems the intention was to have the date as year, month, day, hour, minute, second. However, %h is a shortened month name like Aug, and %m is month. This way, month appears three time in the tag, for no reason. The correct format is %H for hours, %M for minutes and %S for seconds. **Release note**: ```release-note NONE ```
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* Fix for wrong doc of env vars, clarifications, formatting ```release-note Improvements to the mesh expansion / vm setup script ``` * Drop dependency on ISTIO_VERSION, clarify secret prefix vs svc account * Show what we wait for, more cleanup * Removed mixer-server * More fixes - use urls from istio.VERSION; check for dnsmasq Former-commit-id: 79a9916
wattli
pushed a commit
to wattli/istio
that referenced
this pull request
Nov 9, 2017
) * Fix for wrong doc of env vars, clarifications, formatting ```release-note Improvements to the mesh expansion / vm setup script ``` * Drop dependency on ISTIO_VERSION, clarify secret prefix vs svc account * Show what we wait for, more cleanup * Removed mixer-server * More fixes - use urls from istio.VERSION; check for dnsmasq Former-commit-id: 5ccd727
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.