adding Frank as review & approver #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Lin as reviewer. Frank is #1 contributor to Istio repo, he is well deserved to be on both :)
|
/lgtm |
rshriram
approved these changes
Oct 6, 2017
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
Former-commit-id: 2b5c8ad571b3f0618b14279955ec6c7dc9d691e2
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
Former-commit-id: 87954a527ed8b5056fceae24f572e8cfd67912ad
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and Lin as reviewer. Frank is #1 contributor to Istio repo, he is well deserved to be on both :)