can reproduce with

diff --git a/pilot/pkg/networking/core/v1alpha3/cluster.go b/pilot/pkg/networking/core/v1alpha3/cluster.go
index a1c4dd9f9b..8e1a639587 100644
--- a/pilot/pkg/networking/core/v1alpha3/cluster.go
+++ b/pilot/pkg/networking/core/v1alpha3/cluster.go
@@ -135,52 +135,60 @@ func isClusterForServiceRemoved(cluster string, hostName string, svc *model.Serv
 
 // buildClusters builds clusters for the proxy with the services passed.
 func (configgen *ConfigGeneratorImpl) buildClusters(proxy *model.Proxy, req *model.PushRequest,
-	services []*model.Service) ([]*discovery.Resource, model.XdsLogDetails) {
+	services []*model.Service,
+) ([]*discovery.Resource, model.XdsLogDetails) {
 	clusters := make([]*cluster.Cluster, 0)
-	resources := model.Resources{}
-	envoyFilterPatches := req.Push.EnvoyFilters(proxy)
-	cb := NewClusterBuilder(proxy, req, configgen.Cache)
-	instances := proxy.ServiceInstances
-	cacheStats := cacheStats{}
-	switch proxy.Type {
-	case model.SidecarProxy:
-		// Setup outbound clusters
-		outboundPatcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_SIDECAR_OUTBOUND}
-		ob, cs := configgen.buildOutboundClusters(cb, proxy, outboundPatcher, services)
-		cacheStats = cacheStats.merge(cs)
-		resources = append(resources, ob...)
-		// Add a blackhole and passthrough cluster for catching traffic to unresolved routes
-		clusters = outboundPatcher.conditionallyAppend(clusters, nil, cb.buildBlackHoleCluster(), cb.buildDefaultPassthroughCluster())
-		clusters = append(clusters, outboundPatcher.insertedClusters()...)
-
-		// Setup inbound clusters
-		inboundPatcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_SIDECAR_INBOUND}
-		clusters = append(clusters, configgen.buildInboundClusters(cb, proxy, instances, inboundPatcher)...)
-		// Pass through clusters for inbound traffic. These cluster bind loopback-ish src address to access node local service.
-		clusters = inboundPatcher.conditionallyAppend(clusters, nil, cb.buildInboundPassthroughClusters()...)
-		clusters = append(clusters, inboundPatcher.insertedClusters()...)
-	default: // Gateways
-		patcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_GATEWAY}
-		ob, cs := configgen.buildOutboundClusters(cb, proxy, patcher, services)
-		cacheStats = cacheStats.merge(cs)
-		resources = append(resources, ob...)
-		// Gateways do not require the default passthrough cluster as they do not have original dst listeners.
-		clusters = patcher.conditionallyAppend(clusters, nil, cb.buildBlackHoleCluster())
-		if proxy.Type == model.Router && proxy.MergedGateway != nil && proxy.MergedGateway.ContainsAutoPassthroughGateways {
-			clusters = append(clusters, configgen.buildOutboundSniDnatClusters(proxy, req, patcher)...)
+
+	for i := 0; i < 100000; i++ {
+		c := &cluster.Cluster{
+			Name: fmt.Sprint(i),
+			AltStatName: req.Push.PushVersion,
+			ClusterDiscoveryType: &cluster.Cluster_Type{Type: cluster.Cluster_EDS},
 		}
-		clusters = append(clusters, patcher.insertedClusters()...)
+		maybeApplyEdsConfig(c)
+		clusters = append(clusters, c)
 	}
+	resources := model.Resources{}
+	//envoyFilterPatches := req.Push.EnvoyFilters(proxy)
+	//cb := NewClusterBuilder(proxy, req, configgen.Cache)
+	//instances := proxy.ServiceInstances
+	//cacheStats := cacheStats{}
+	//switch proxy.Type {
+	//case model.SidecarProxy:
+	//	// Setup outbound clusters
+	//	outboundPatcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_SIDECAR_OUTBOUND}
+	//	ob, cs := configgen.buildOutboundClusters(cb, proxy, outboundPatcher, services)
+	//	cacheStats = cacheStats.merge(cs)
+	//	resources = append(resources, ob...)
+	//	// Add a blackhole and passthrough cluster for catching traffic to unresolved routes
+	//	clusters = outboundPatcher.conditionallyAppend(clusters, nil, cb.buildBlackHoleCluster(), cb.buildDefaultPassthroughCluster())
+	//	clusters = append(clusters, outboundPatcher.insertedClusters()...)
+	//
+	//	// Setup inbound clusters
+	//	inboundPatcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_SIDECAR_INBOUND}
+	//	clusters = append(clusters, configgen.buildInboundClusters(cb, proxy, instances, inboundPatcher)...)
+	//	// Pass through clusters for inbound traffic. These cluster bind loopback-ish src address to access node local service.
+	//	clusters = inboundPatcher.conditionallyAppend(clusters, nil, cb.buildInboundPassthroughClusters()...)
+	//	clusters = append(clusters, inboundPatcher.insertedClusters()...)
+	//default: // Gateways
+	//	patcher := clusterPatcher{efw: envoyFilterPatches, pctx: networking.EnvoyFilter_GATEWAY}
+	//	ob, cs := configgen.buildOutboundClusters(cb, proxy, patcher, services)
+	//	cacheStats = cacheStats.merge(cs)
+	//	resources = append(resources, ob...)
+	//	// Gateways do not require the default passthrough cluster as they do not have original dst listeners.
+	//	clusters = patcher.conditionallyAppend(clusters, nil, cb.buildBlackHoleCluster())
+	//	if proxy.Type == model.Router && proxy.MergedGateway != nil && proxy.MergedGateway.ContainsAutoPassthroughGateways {
+	//		clusters = append(clusters, configgen.buildOutboundSniDnatClusters(proxy, req, patcher)...)
+	//	}
+	//	clusters = append(clusters, patcher.insertedClusters()...)
+	//}
 
 	for _, c := range clusters {
 		resources = append(resources, &discovery.Resource{Name: c.Name, Resource: util.MessageToAny(c)})
 	}
-	resources = cb.normalizeClusters(resources)
+	//resources = cb.normalizeClusters(resources)
 
-	if cacheStats.empty() {
-		return resources, model.DefaultXdsLogDetails
-	}
-	return resources, model.XdsLogDetails{AdditionalInfo: fmt.Sprintf("cached:%v/%v", cacheStats.hits, cacheStats.hits+cacheStats.miss)}
+	return resources, model.XdsLogDetails{}
 }
 
 func shouldUseDelta(updates *model.PushRequest) bool {
diff --git a/pilot/pkg/xds/ads.go b/pilot/pkg/xds/ads.go
index e0cfa8ccff..a66e7df456 100644
--- a/pilot/pkg/xds/ads.go
+++ b/pilot/pkg/xds/ads.go
@@ -162,6 +162,9 @@ func (s *DiscoveryServer) receive(con *Connection, identities []string) {
 		}
 		// This should be only set for the first request. The node id may not be set - for example malicious clients.
 		if firstRequest {
+			if req.TypeUrl != v3.ClusterType && req.TypeUrl != v3.SecretType {
+				log.Fatalf("unexpected type %v", req.TypeUrl)
+			}
 			// probe happens before envoy sends first xDS request
 			if req.TypeUrl == v3.HealthInfoType {
 				log.Warnf("ADS: %q %s send health check probe before normal xDS request", con.PeerAddr, con.ConID)

proxy-local --proxyLogLevel=config:debug and pilot-local "--keepaliveMaxServerConnectionAge=3s".

Limit envoy cpu: sudo cpulimit --pid $( ps aux | rg envoy | rg howardjohn | awk '{print $2}') --limit 20

send lots of pushes: while :; do curl localhost:8080/debug/adsz?push=true; sleep .5; done

TestReachability flake; cluster warming #39720

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions