enableNamespacesByDefault doesn't work when revision tag is there and previous configuration has enableNamespacesByDefault disabled #39604
Description
Bug Description
enableNamespacesByDefault doesn't work when revision tag is there and the previous configuration had enableNamespacesByDefault disabled.
Version
$ istioctl version
client version: 1.14.1
control plane version: 1.14.1
data plane version: none
$ kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.24.1
Kustomize Version: v4.5.4
Server Version: v1.22.9-eks-a64ea69
Additional Information
Steps to reproduce
save this as disabledByDefault.yaml :
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
namespace: istio-system
name: istiocontrolplane
spec:
profile: minimal
revision: 1-14-1
save this as enabledByDefault.yaml :
kind: IstioOperator
metadata:
namespace: istio-system
name: istiocontrolplane
spec:
profile: minimal
revision: 1-14-1
values:
sidecarInjectorWebhook:
enableNamespacesByDefault: true
Do:
$ istioctl install -f disabledByDefault.yaml
Then do:
$ istioctl install -f enabledByDefault.yaml
The configmap istio-sidecar-injector-1-14-1 shows "enableNamespacesByDefault": true,
But sidecar injection does not work when a pod is created.