Skip to content

SidecarScope.DependsOnConfig is not correct for DestinationRule #38082

@hzxuzhonghu

Description

@hzxuzhonghu

We do merge DRs for push context, so when sidecar scope AddConfigDependencies, we lost the some original configs info.

Then when a dr(merged into another dr) is updated, we could skip push xds to a proxy.

// Compute and send the new configuration for a connection.
func (s *DiscoveryServer) pushConnection(con *Connection, pushEv *Event) error {
	pushRequest := pushEv.pushRequest

	if pushRequest.Full {
		// Update Proxy with current information.
		s.updateProxy(con.proxy, pushRequest)
	}

	if !s.ProxyNeedsPush(con.proxy, pushRequest) {

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions