-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Open
Labels
area/test and releaselifecycle/staleproofIndicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closedIndicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Description
Some integration tests use public URLs to access files. This is problematic for a few reasons:
- Adds a dependency on external service, making tests not hermetic. This has broken us before
- Does not work in airgap env
- Does not work for ipv6 testing.
- In our current setup we have no external connectivity for ipv6 clusters
- Even if we did, github does not support ipv6 it seems
Currently I know we use this for the JWKS and attributegen, but there may be others.
Proposed solution: Deploy a trivial file server that serves plaintext + HTTPS into istio-system for tests that require it
Metadata
Metadata
Assignees
Labels
area/test and releaselifecycle/staleproofIndicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closedIndicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed