Skip to content

Change grpc_status from string to int32 in fault abort #24698

@ckcd

Description

@ckcd

Describe the feature request
In virtual_service.proto we set grpc_status as string (and it's hide_from_docs for now). It's a little confused why it's string rather than int32. Maybe a int32 in 0-16 range is more efficient.

And envoy support grpc_status in v3, see: PR and proto, and it set grpc_status as a int32.

BTW don't know whether it's some compatibility issues if we do this change.

Describe alternatives you've considered

  1. Change grpc_status from string to int32 in fault abort protos.
  2. Implement this feature after we move to envoy v3.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions