-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Closed
Labels
area/networkingkind/enhancementlifecycle/automatically-closedIndicates a PR or issue that has been closed automatically.Indicates a PR or issue that has been closed automatically.lifecycle/staleIndicates a PR or issue hasn't been manipulated by an Istio team member for a whileIndicates a PR or issue hasn't been manipulated by an Istio team member for a while
Description
Describe the feature request
In virtual_service.proto we set grpc_status
as string
(and it's hide_from_docs
for now). It's a little confused why it's string
rather than int32
. Maybe a int32
in 0-16
range is more efficient.
And envoy support grpc_status in v3, see: PR and proto, and it set grpc_status as a int32
.
BTW don't know whether it's some compatibility issues if we do this change.
Describe alternatives you've considered
- Change
grpc_status
from string to int32 in fault abort protos. - Implement this feature after we move to envoy v3.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Metadata
Metadata
Assignees
Labels
area/networkingkind/enhancementlifecycle/automatically-closedIndicates a PR or issue that has been closed automatically.Indicates a PR or issue that has been closed automatically.lifecycle/staleIndicates a PR or issue hasn't been manipulated by an Istio team member for a whileIndicates a PR or issue hasn't been manipulated by an Istio team member for a while