@ayj I am new to contributions in istio. I tried to do some initial research, I might have missed something, but if you could point to some direction it will be great.

For instance, I guess (please correct me), istio uses cobra - hope I am right.

When I further checked, the interface expects to use a function called BashCompletionFunction. Or ValidArgs, etc.

I don't find any occurrence of that in the code base:

find . -name "*.go" | xargs grep -r "BashCompletionFunction"
./vendor/github.com/spf13/cobra/bash_completions.go:	if len(c.BashCompletionFunction) > 0 {
./vendor/github.com/spf13/cobra/bash_completions.go:		buf.WriteString(c.BashCompletionFunction + "\n")
./vendor/github.com/spf13/cobra/command.go:	// BashCompletionFunction is custom functions used by the bash autocompletion generator.
./vendor/github.com/spf13/cobra/command.go:	BashCompletionFunction string

Am I in the right track? Since you have mentioned it worked earlier, I am just curious when exactly was it working as I did not find any occurrences in the whole repo.

Please help.

fix istioctl bash completion #6119

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions