Gatway TCP broken #5964
Description
Pilot incorrectly generates destination_ip_list for gatway TCP;
"cluster": "outbound|5202||iperf3-raw.test.svc.cluster.local",
"destination_ip_list": [
"10.11.255.239/32"
That's correct for sidecars, but not for gateway since the destination ip is the gatway address.
We should add it to 0.8.1 - since gateway TCP is a new feature we can probably document that
it's not ready in 0.8.0
A possible fix ( I tested it work, but you may want to do it differnetly):
diff --git a/pilot/pkg/networking/core/v1alpha3/gateway.go b/pilot/pkg/networking/core/v1alpha3/gateway.go
index cde6b457d..b32f1652e 100644
--- a/pilot/pkg/networking/core/v1alpha3/gateway.go
+++ b/pilot/pkg/networking/core/v1alpha3/gateway.go
@@ -350,7 +350,7 @@ func buildGatewayNetworkFilters(env model.Environment, server *networking.Server
}
filters = append(filters, buildOutboundNetworkFilters(
istio_route.GetDestinationCluster(dest, upstream, int(server.Port.Number)),
- []string{upstream.Address}, port)...)
+ []string{model.UnspecifiedIP}, port)...)
}
return filters
}