Verify unit tests for _istioctl_ are run during build #5202
Description
When I run go test ./istioctl/... locally TestValuesFromInstallation fails because it wants 0.4 tags and receives 0.7.1 tags. Greg also reported a problem with the new testdata merged with PR #5178
Using HEAD, @GregHanson reports
$ go test ./istioctl/...
? istio.io/istio/istioctl/cmd/istioctl [no test files]
2018-04-25T19:26:59.883721Z warn Source matching not supported
2018-04-25T19:26:59.885446Z warn Source matching not supported
2018-04-25T19:26:59.887957Z warn Source matching not supported
--- FAIL: TestCommand (0.03s)
--- FAIL: TestCommand/nolabel-destination-rule.yaml (0.00s)
cmd_test.go:101: open testdata/v1alpha1/nolabel-destination-policy.yaml: no such file or directory
FAIL
FAIL istio.io/istio/istioctl/cmd/istioctl/convert 0.100s
--- FAIL: TestValuesFromInstallation (0.00s)
--- FAIL: TestValuesFromInstallation/default (0.00s)
helm_test.go:36: valuesFromInstallation(&{istio-system gcr.io/istio-testing 0.7.1 0.7.1 0.7.1 0.7.1 quay.io/coreos/hyperkube v1.7.6_coreos.0 0 false true true true true false})
got "global:\n namespace: istio-system\n sidecar-injector:\n enabled: false\n proxy:\n hub: gcr.io/istio-testing\n tag: 0.7.1\n debug: false\n pilot:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.7.1\n security:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.7.1\n mixer:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.7.1\n ingress:\n use_nodeport: false\n nodeport_port: 0\n hyperkube_hub: quay.io/coreos/hyperkube\n hyperkube_tag: v1.7.6_coreos.0\n"
want "global:\n namespace: istio-system\n sidecar-injector:\n enabled: false\n proxy:\n hub: gcr.io/istio-testing\n tag: 0.4.0\n debug: false\n pilot:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.4.0\n security:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.4.0\n mixer:\n enabled: true\n hub: gcr.io/istio-testing\n tag: 0.4.0\n ingress:\n use_nodeport: false\n nodeport_port: 0\n hyperkube_hub: quay.io/coreos/hyperkube\n hyperkube_tag: v1.7.6_coreos.0\n"
FAIL
FAIL istio.io/istio/istioctl/cmd/istioctl/gendeployment 0.022s
? istio.io/istio/istioctl/pkg/convert [no test files]
Metadata
Metadata
Assignees
Labels
No labels