Skip to content

Change from BlackFriday to Goldmark for generated docs in istio/tools. #41377

@ericvn

Description

@ericvn

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)

Describe the feature request

Move the proton-gen-docs from using github.com/russross/blackfriday/v2 to https://github.com/yuin/goldmark

The istio.io site moved from using BlackFriday to Goldmark as Hugo had deprecated and removed BlackFriday. I notice we still use BlackFriday in the get-docs code. Although I haven't seen any issues with the generated code/pages, it might be beneficial to move to the same as used by istio.io.

Describe alternatives you've considered

None. Maybe there is a better library to use, but I didn't find one.

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions